coreui / coreui-pro / 36140927236

96%

main: 94%

push

github

refactor: build the UMD entry from the module index (#1434)

* refactor: build the UMD entry from the module index

js/index.umd.js listed every component twice, as an import and as a key of its default export, next to js/src/index.ts, which the ESM build reads. Nothing compared the two lists, so a component added to one and forgotten in the other would have been missing from window.coreui with every check green. The UMD entry now re-exports js/src/index.ts and adds only the OffCanvas alias, so the two builds cannot drift.

window.coreui keeps the same 47 names pointing at the same plugins, checked in Chromium on coreui.bundle.js, coreui.min.js and bootstrap.bundle.js, with a tooltip and the alert data API working in each. The global is now filled through exports rather than returned, so Object.prototype.toString reports it as [object Module]. Minified sizes move by -15 B (coreui.min.js) and +17 B (coreui.bundle.min.js) gzip.

js/tests/unit/index.spec.js fails when a module in js/src is not exported from the index (the five base modules excepted), when the UMD entry misses a module export, and when the OffCanvas alias goes.

* refactor: keep the UMD global a plain object

With named exports rolldown tagged the exports object with Symbol.toStringTag "Module", so Object.prototype.toString reported window.coreui as [object Module] and lodash's cloneDeep returned {} for it and isPlainObject false. generatedCode.symbols is off for the bundles now; the only change in the eight UMD files is that line, and the ESM bundles are byte-identical.

The export spec globs module namespaces instead of default imports, so a module in js/src without a default export is listed as missing instead of failing the spec file at link time.

6104 of 6663 branches covered (91.61%)

Branch coverage included in aggregate %.

11201 of 11521 relevant lines covered (97.22%)

722.97 hits per line