coreui / coreui-pro / 36130049761

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(RangeSlider): let setConfig rebuild the slider without stacking listeners (#1431)

* fix(RangeSlider): let setConfig rebuild the slider without stacking listeners

setConfig() rebuilt the slider through _initializeRangeSlider(), which
registered its four delegated listeners on the host as new arrow
functions every time. EventHandler skips only an identical function, so
after N calls one native input fired N + 1 input and change events. The
rebuild also kept the tooltips of the first render, so the visible ones
never showed the new value, and the disabled and vertical classes stayed
on after those options were turned off.

The four handlers are now instance fields, registered once and removed by
reference when the slider is disabled, so switching disabled with
setConfig works both ways. setConfig starts from empty input and tooltip
lists and removes the disabled and vertical classes when it turns those
options off.

* build: raise the coreui.js and coreui.esm.js budgets

Keeping the RangeSlider handlers as instance fields and resetting its
lists and classes in setConfig grows coreui.js by 128 B and
coreui.esm.js by 126 B gzip against v6-dev (148657 -> 148785 B and
147602 -> 147728 B, Node zlib level 9 as bundlewatch measures, both
builds in one tree), 49 B and 16 B over their ceilings. Both move up by
0.5 KB. coreui.bundle.js stays 25 B under its ceiling and keeps it.

* fix(RangeSlider): end a drag when setConfig rebuilds the slider

A drag that setConfig interrupted kept going: the next mousemove moved a
slider disabled in the same call, and one whose values the call reduced
threw on the index of a thumb that no longer existed. setConfig now ends
the drag before it rebuilds. The specs also count change events and
track and tick presses after several calls, and check that a slider
disabled with setConfig ignores both presses.

Coverage Stats

6077 of 6633 branches covered (91.62%)

Branch coverage included in aggregate %.

41 of 41 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

11182 of 11502 relevant lines covered (97.22%)

698.14 hits per line