coreui / coreui-pro / 36127735855

96%

main: 94%

push

github

fix(OTPInput): let setConfig turn disabled, readonly and placeholder off again (#1429)

* fix(OTPInput): let setConfig turn disabled, readonly and placeholder off again

The slots only ever received disabled, readonly and placeholder: false or
null left them as they were. setConfig({ disabled: false }) after
setConfig({ disabled: true }) kept every slot disabled while the hidden
input, rebuilt from the config, was enabled again, so the user could not
type and the form posted an empty code. readonly and a placeholder could
not be removed either.

The component remembers what each slot carried in its markup and applies
the three options both ways: a slot is disabled or read-only when the
option or its markup says so, and without a placeholder option it gets
its markup placeholder back or none.

* fix(OTPInput): take back only what the options set on the slots

The first version replayed a snapshot of the slots' markup, taken at
construction, on every setConfig, so a value-only call re-enabled a slot
the page had disabled after init, re-disabled one it had enabled, and
stripped a slot added later of its placeholder and readonly.

The component now records the slots it disabled or made read-only itself
and the placeholder each slot had before it wrote its own, and turning
an option off undoes only that. Calls that do not change these options
leave the slots as they are, and dispose() gives back what the options
set, so a new instance on the same element starts from the page's markup.

6069 of 6625 branches covered (91.61%)

Branch coverage included in aggregate %.

27 of 27 new or added lines in 1 file covered. (100.0%)

11168 of 11486 relevant lines covered (97.23%)

698.02 hits per line