coreui / coreui-pro / 36125360714

96%

main: 94%

push

github

fix(Menu, Popup): keep a panel with an explicit container inside an open dialog (#1427)

* fix(Menu, Popup): keep a panel with an explicit container inside an open dialog

A modal dialog makes everything outside it inert. resolvePopupContainer
kept a panel inside an open dialog only when no container was given and
returned an explicit container as is, and Menu never looked for a
dialog at all. A Menu, Dropdown or ContextMenu, a MultiSelect,
Autocomplete or Combobox, or a picker opened from a modal dialog with
container: 'body' put its panel in the inert page, where it could not be
clicked or reached with the keyboard.

resolvePopupContainer now returns the open dialog when the explicit
container lies outside it, and Menu resolves its container through it,
so all of them keep the panel inside the dialog. A container inside the
dialog is kept, and a container selector that matches nothing still
leaves the menu in place. Tooltip keeps its own rule for the body.

* build: raise the coreui.js budget

Keeping a panel inside an open dialog grows coreui.js by 140 B gzip
against v6-dev (148092 -> 148232 B, Node zlib level 9 as bundlewatch
measures, both builds in one tree), 8 B over its 144.75 KB ceiling.
About 115 B of that is the JSDoc the util now carries, which the
unminified bundles keep; the minified ones grow by 20 to 24 B. The
ceiling moves up by 0.5 KB.

* fix(Popup): hand an explicit container over only to a modal dialog

The dialog rule matched any open dialog, so a panel with container:
'body' opened from a dialog shown without showModal(), such as an
Offcanvas that keeps the page scrollable, was pulled into that dialog
although nothing outside it was inert. There it could be clipped by the
dialog's overflow, and Escape on a menu item reached the dialog's own
Escape handling and closed the whole offcanvas. Only a modal dialog now
takes the panel over.

The specs tell a modal dialog from one that is not, and a panel moved
into the dialog from one le... (continued)

6056 of 6613 branches covered (91.58%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

11141 of 11463 relevant lines covered (97.19%)

698.57 hits per line