coreui / coreui-pro / 36117210120

96%

main: 94%

push

github

fix(ChipSet): dispose the chips it created (#1425)

* fix(ChipSet): dispose the chips it created

ChipSet.dispose() left every Chip instance it had set up in the Data map,
with its listeners and the remove button it appended. A chip stayed
removable after its set was gone, and a ChipSet created again on the same
element got the old instances back from getOrCreateInstance, so new
options such as removable: false never reached the chips.

The set now keeps the instance it created for each chip and disposes it
when that instance is still the chip's and the chip is still inside the
set, so a chip the page initialized itself or moved to another set is
left alone. It also removes the role, aria-orientation and
aria-multiselectable it set on itself and the option role it gave its
chips. Chip.dispose() takes back the remove button and check icon it
appended and the role, tabindex, ARIA attributes, chip-clickable and
disabled classes it set; whatever the markup had stays. A second
dispose() is a no-op. The chips stay in the document, including those
added with add().

A remove button written in the markup no longer removes a chip that is
not removable or is disabled; the keyboard path already checked both.

ChipInput inherits the change. MultiSelect creates its chips before its
selection set and disposes them itself, so the set does not own them.

* build: raise the coreui.esm.js and coreui.bundle.js budgets

Disposing the chips a ChipSet created and taking back what a chip added
grows the JS bundles against v6-dev by 320 to 340 B gzip unminified and
228 to 240 B minified, measured with Node zlib level 9 as bundlewatch
does, on both builds in the same tree. coreui.esm.js goes from 146593 to
146933 B, 245 B over its 143.25 KB ceiling, and coreui.bundle.js from
157845 to 158166 B, 214 B over 154.25 KB, so both move up by 0.5 KB.
coreui.js stays under its ceiling and keeps it.

6039 of 6597 branches covered (91.54%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 2 files covered. (100.0%)

11110 of 11437 relevant lines covered (97.14%)

657.78 hits per line