coreui / coreui-pro / 36112095054

96%

main: 94%

push

github

fix(Calendar): keep the view on a pick and stop page keys at the bounds (#1423)

* fix(Calendar): keep the view on a pick and stop page keys at the bounds

Picking a date no longer sets the calendar date or fires
calendarDateChange. The click handler stored the picked day as the
calendar date without redrawing, so after picking a day of an adjacent
month (selectAdjacentDays) the grid showed one month while the calendar
held the next: the next-month button skipped a month and the arrows
counted from the wrong page. The picked adjacent day now stays where it
is and shows as selected with a 1px border in the new
--cui-calendar-cell-selected-adjacent-color instead of a fill.

Page Up / Page Down past minDate or maxDate now focus the last
selectable date before the bound and turn the calendar only when that
date lies outside the months the panels show. They used to clamp the
target to the bound and page by the month difference: inside the shown
month that was a page by zero, a redraw and a calendarDateChange for the
same month, and a week row starting before a maxDate early in the month
paged into an empty month. The bound is now tested the way the grid
disables a date, a week row by its first day, so a minDate carrying a
time no longer pages into a month with nothing selectable. From a day of
an adjacent month the focus moves to the same day a month away and the
calendar turns only as far as that takes.

Home / End and the page keys share the walk to a selectable date, and a
page action from a cell carries a year as years, the way the grid's page
action already did.

* fix(Calendar): keep the selected colour under the pointer and tint the picked adjacent day

A selected day or week under the pointer took the plain hover colour, so a
click showed nothing until the pointer left. It now shows the selected fill a
shade darker (--cui-calendar-cell-selected-hover-bg,
--cui-calendar-cell-selected-hover-color).

The picked day of an adjacent month keeps its outli... (continued)

6024 of 6581 branches covered (91.54%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 1 file covered. (100.0%)

11075 of 11402 relevant lines covered (97.13%)

657.08 hits per line