coreui / coreui-pro / 36119396589

96%

main: 94%

push

github

fix(Menu): remove the submenu listeners on dispose (#1426)

Menu registered four submenu listeners on the menu element (mouseenter,
mouseleave, mousemove and click) and dispose() never removed them. After
dispose() every submenu event reached the nulled instance and threw a
TypeError, and each re-initialization on the same element added another
set.

Each instance now keeps the listeners it registered and dispose()
removes exactly those, so another Menu, Dropdown or ContextMenu sharing
the same menu element, as the shared context menu in the docs does,
keeps its own. The mouseenter listener an open submenu puts on its panel
is removed by reference when the submenu closes, instead of every
mouseenter handler on the panel, so handlers that other code or another
instance registered there stay.

6043 of 6601 branches covered (91.55%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 1 file covered. (100.0%)

11121 of 11448 relevant lines covered (97.14%)

658.6 hits per line