moonbitlang / core / 6783

89%

push

github

refactor: deprecate stray live legacy aliases and default() free functions (#4281)

Names that are deprecated on most types but were still live on a few:

- `iterator` / `iterator2` aliases on `Iter` and `Iter2` (deprecated on
  every other type: Array, ArrayView, Map, Option, the collections, ...)
- `Iter::count`'s `length` alias: `length` is O(1) and non-destructive
  on every container, but on `Iter` it drains the iterator
- `List::prepend`'s `add` alias: it made `xs.add(y)` (prepend) disagree
  with `xs + ys` (the `Add` impl, which concatenates)
- `@list.default()` / `@uint.default()`: AGENTS.md deprecates free
  `default` promotions (`@float.default` and `@unit.default` already
  are); use a literal or `Default::default()`

Migrate in-repo callers (List buckets in immut/hashmap and
immut/hashset HAMTs, quickcheck/shrink, tests).

Part of #4272.

Codex review: "Approved; no blocking issues. All rewritten calls preserve semantics, deprecation messages are accurate, and interface changes contain only deprecation markers."

Signed-off-by: Codex CLI <codex@openai.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

26 of 26 new or added lines in 3 files covered. (100.0%)

16501 of 18393 relevant lines covered (89.71%)

315270.78 hits per line