moonbitlang / core
91%

DEFAULT BRANCH: main
Repo Added
Files 382
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 91.221% (+0.001%) from 91.22%
5143

push

github

web-flow 
perf(bigint): build to_string digits in one pass instead of prepending (#3709)

* perf(bigint): build to_string digits in one pass instead of prepending

The base-10 `BigInt::to_string` emitted each decimal digit with
`ret = digit.to_string() + ret`, prepending into a freshly allocated
string on every digit. That is quadratic in the digit count and
allocates a one-char string plus a full copy of the accumulator per
digit.

Emit the digits least-significant-first into a pre-sized
`FixedArray[Char]` and materialize the result string once. The
limb->decimal base-conversion loop above this is a separate O(n^2) cost
and is left untouched; this only removes the quadratic string building
in the digit-emission phase.

Bench (BigInt::to_string, native):
    40 digits:  649.9 ns -> 148.1 ns  (4.4x)
   400 digits:    9.73 µs ->  2.76 µs (3.5x)
  4000 digits:  410.4 µs -> 194.5 µs  (2.1x)

Adds bigint/to_string_bench_test.mbt to cover the path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* test(bigint): guard make_decimal against non-positive digit counts

Addresses review feedback: make_decimal claimed to produce exactly
`digits` digits but silently misbehaved for digits <= 0 (it still built
"1" and passed a negative size_hint to StringBuilder). Fail loudly on
misuse instead.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

9 of 9 new or added lines in 1 file covered. (100.0%)

15628 of 17132 relevant lines covered (91.22%)

191916.19 hits per line

Relevant lines Covered
17132 RELEVANT LINES 15628 COVERED LINES
191916.19 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
5143 main perf(bigint): build to_string digits in one pass instead of prepending (#3709) * perf(bigint): build to_string digits in one pass instead of prepending The base-10 `BigInt::to_string` emitted each decimal digit with `ret = digit.to_string() + re... push web-flow github
91.22
5142 perf/bigint-tostring-linear Merge 78f78e37e into b6a0f0310 Pull #3709 web-flow github
91.22
5140 main Replace find_match_range with labeled unsafe_range_equal Give Bytes::unsafe_range_equal labeled offsets/length (self_off~, other_off~, len~) so call sites are self-describing, and inline the find_match_range wrapper into its callers. Full-length ... push bobzhang github
91.22
5139 refactor/bytes-find-range-equal Merge 2a6af3241 into f9fb3f4d0 Pull #3804 web-flow github
91.22
5137 main fix check warnings push myfreess github
91.3
5135 fix-warnings Merge 91e03d297 into c2f8907ea Pull #3803 web-flow github
91.3
5134 fix-warnings Merge e8e9fe9e0 into c2f8907ea Pull #3803 web-flow github
91.3
5133 main Document byte search declarations push bobzhang github
91.3
5132 perf/bytes-rev-find-fast Merge 4e2f10e24 into 85554fb12 Pull #3785 web-flow github
91.3
5130 perf/bytes-rev-find-fast Merge 9d0bc6f28 into 85554fb12 Pull #3785 web-flow github
91.3
See All Builds (9989)