hyperledger-labs / fabric-smart-client / 36056587838

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(grpc): report an error from SetClientRootCAs when TLS is disabled (#1885)

SetClientRootCAs ended in gServer.tls.SetClientCAs without checking that
gServer.tls is set. The field is assigned only in the UseTLS branch of the
constructor, so on a server created without TLS it is nil and the call
panicked: TLSConfig.SetClientCAs takes its lock as the first statement, so
a nil receiver fails immediately. The method is exported and needs no
special input to reach.

Guard it with TLSEnabled, which exists for this check and which
MutualTLSRequired already uses before dereferencing the same field, and
report the missing configuration as an error. Calling it while gServer.lock
is held is safe: TLSEnabled takes no lock, and gServer.tls is written once
during construction.

The internal appendClientRootCA dereferences the same field but runs only
inside the UseTLS branch, so it is left unchanged.

Fixes #1884

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

27708 of 32092 relevant lines covered (86.34%)

2754.07 hits per line