hyperledger-labs / fabric-smart-client / 36018661267

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(kvs): reject a cache size below 1 instead of panicking on the first write (#1883)

CacheSizeFromConfig validated only cacheSize < 0 and returned a configured
0 unchanged. KVS.New passes that straight to secondcache.New, which
allocates a fixed slice of that length, so the first write panicked with
"index out of range [0] with length 0": addLocked finds num < size false
when both are 0, enters the victim scan, and indexes an empty slice.
GetOrLoad reaches the same code, and NewBytes mirrors it with an
unbounded scan loop.

The KVS cannot honour 0 as "caching disabled": the cache interface has one
implementation, KVS.New hardwires it, and all nine call sites use it
unconditionally. That is unlike vault.NewCachedVault, where 0 selects a
bypassing notCachedStore. Since newKVS already propagates a config error
and fails startup, report the invalid size there rather than constructing
a cache that cannot work.

Document the minimum on both constructors and resolve the open question
about 0 in the core.yaml reference.

Fixes #1882

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

16 existing lines in 6 files now uncovered.

27697 of 32089 relevant lines covered (86.31%)

2350.08 hits per line