hyperledger-labs / fabric-smart-client / 36057013037

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): return the declared errors instead of panicking (#1887)

crypto.provider.Hash declares an error return but panicked when the BCCSP
hasher failed, discarding the cause: the panic value named the message
without saying what went wrong. RWSetProcessor.Process returns an error on
every other failure in its write loop but panicked on fieldMappingKey.
That key comes from rws.GetWriteAt, so it is a write key out of the
transaction's read-write set, and a malformed composite key panicked the
committer rather than failing the transaction.

Return wrapped errors from both, preserving the cause. GetHash cannot
report a failure through its signature, so widen it to
(hash.Hash, error); the package has no importers and no interface
constrains it.

The two provider tests asserted the panics with require.PanicsWithError,
so they now assert the returned errors and that the cause survives.

Fixes #1886

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

3 of 4 new or added lines in 2 files covered. (75.0%)

17 existing lines in 8 files now uncovered.

27705 of 32095 relevant lines covered (86.32%)

2815.14 hits per line