hyperledger-labs / fabric-smart-client / 36018268770

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric/delivery): classify commit failures instead of stopping the channel on any error (#1840)

A single error returned by Committer.Commit permanently stopped the channel's
block delivery. Delivery is single-use by design, nothing supervised it, and
nothing reported the stop, so one transient storage fault silently ended block
ingestion for that channel: the vault stopped advancing, finality notifications
stopped firing, and IsFinal degraded to a peer probe followed by a timeout that
reads downstream as an ordering or peer problem. The stream half of the same
service already reconnects indefinitely on gRPC failure, so stream faults
self-healed while committer faults were fatal.

Classify the failure in the committer and act on the class:

  - retry   non-deterministic and replay-safe (storage contention, an expired
            context): commit the same block again, bounded, then escalate
  - degrade deterministic on an already-final block, such as a configuration
            this node cannot apply: return the error, which stops the channel,
            and count it
  - fatal   an invariant is broken, so committing further blocks would build on
            state the node cannot vouch for

Classification belongs to the committer because it is the component that can
tell the cases apart: it owns the vault, so it knows which storage errors are
contention that will clear; the membership service, so it knows a configuration
it could not apply never will; and the channel configuration, so it knows how
long to keep trying. A caller further up sees only an error value and would have
to import those packages to reach the same answer.

That makes the contract simple in both directions. Commit returns only final
errors, so readBlocks stops on any error without inspecting one — which is what
its own doc comment always described. It also keeps the retry away from the
delivery service's other callers: Scan, ScanBlock and ScanFromBlock run the
application's own... (continued)

Coverage Stats

96 of 101 new or added lines in 6 files covered. (95.05%)

14 existing lines in 8 files now uncovered.

27699 of 32089 relevant lines covered (86.32%)

2287.01 hits per line