hyperledger-labs / fabric-smart-client / 35966970544

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(state): bound-check the stream At methods (#1881)

outputStream.At, inputStream.At and commandStream.At indexed their
backing slice with no bounds check, so an out-of-range position panicked.
Filter returns an empty stream when nothing matches, and the integration
views index the result of a Filter against a transaction received from a
remote party, so the position is not always known to be in range.

Return nil out of range, as Block.DataAt already does for a malformed
remote block. Since callers chain off the result, output.State,
input.State and input.VerifyCertification report a nil receiver as an
error, matching Namespace.GetOutputAt, which wraps a bad index.

output.ID, output.IsDelete and input.ID return a bare value with no error
to carry and keep dereferencing their receiver: a zero ID would hide the
mistake at the call site rather than report it. At documents that, and a
test pins it.

Fixes #1880

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

22 of 22 new or added lines in 2 files covered. (100.0%)

11 existing lines in 5 files now uncovered.

27614 of 31995 relevant lines covered (86.31%)

2760.1 hits per line