coreui / coreui-pro / 36015736923

96%

main: 94%

push

github

refactor(util): move the calendar tab stop into the calendar helpers (#1420)

The rule that decides which cell or week row of a calendar takes the tab
stop lived four times: in getTabStop for the rendered React and Vue
panels, and as DOM code in the vanilla, React and Vue calendars. The DOM
part now sits next to getTabStop: getClosestSelectable picks the cell or
row closest to a date from the dates its cells carry, and
setRovingTabIndex gives each panel one stop, on the focused target, else
the selected one, else the closest, else the first. The calendar calls
the two helpers instead of _closestSelectable and
_updatePanelRovingTabIndex.

The vanilla calendar now follows the rule React and Vue already used,
which changes where focus lands on week rows in two ways. A row is
measured by the first and last day it shows instead of the start of its
week plus six days, so with adjacent days hidden PageDown from the week
of Mar 2 lands on the April row that shows Apr 2, not on the March row
that ends on Mar 31. When two rows are equally close, the row of the
panel's own month wins over one that starts with days of the adjacent
month: in a two-month view PageDown from the week of Jul 6 focuses the
week of Aug 3 in the August panel instead of the row of August days
under July, and with a disabled day in the week of Jul 9 the initial tab
stop goes to the week of Jul 13 instead of the row that starts on
Jun 29. setRovingTabIndex also takes a stale stop off a cell or row that
is no longer a target, which the vanilla code did not do.

5959 of 6533 branches covered (91.21%)

Branch coverage included in aggregate %.

37 of 37 new or added lines in 2 files covered. (100.0%)

11038 of 11372 relevant lines covered (97.06%)

626.6 hits per line