IJHack / QtPass / 36012989720

93%

Build Type

push

github

Committed by web-flow

Commit Message

Split the 10–14 band where a function did several jobs (#1923)

* Split the 10-14 band where a function did several jobs

After no function reached 15, 46 sat between 10 and 14. The grammar
checkers among them (Base32, TOTP URI, WSL command, gpg colon output, the
URL gate, path and link validators) stay as they are: each is one flat list
of rules, and splitting it would scatter the rules. The ones that did several
jobs in one body are now the sequence they were:

- recoverReencryptLeftovers: dropStaleTemporary, restoreBackup and one
  reportUnrestorable for the message it gave twice (14 -> 9).
- Executor::runBlocking: waitOrCancel (14 -> 10).
- UsersDialog::on_importKeyButton_clicked: selectImportedKey (14 -> 4).
- ImitatePass::Insert and reencryption's encryptFor build their gpg
  arguments with one encryptArgs(), as the comment asked ("both belong on
  every encrypt call"); recipientsForEntry() (13 -> 11).
- ImitatePass::Copy: copyDestination (12 -> 8).
- RealPass::passMoveOrCopy: passName (13 -> 11).
- Pass::getGpgIdPath: nearestGpgId walks up (13 -> 6).
- Pass::recipientsForEditing: the verdict-to-preselection mapping is its
  own file-local function (12 -> 5).
- SshAuthSock::initialise: the gpgconf and launchctl probes were the same
  code twice; adoptSocketFrom (12 -> 5).
- TemplateIO::readTemplates and getFolderTemplate: sectionHeader,
  defaultTemplateIn (13 -> 10, 12 -> 8).
- MainWindow's 120-line constructor: connectBackends, initTextBrowser,
  initDisplayPanel, initTimers, initProcessOutput, in the same order
  (11 -> 4).
- PasswordDisplayPanel::addField: addActionButtons, addHiddenPassword,
  valueBrowser, urlButton (10 -> 4).
- ConfigDialog::on_accepted: warnAboutSshAuthSockOverride,
  followActiveProfile (11 -> 1); initializeNewProfiles:
  ensureProfileFolder, initialiseProfileStore (10 -> 5).

No behaviour change. src/: 717 functions, 581 at <= 5, 100 at 6-9, 36 at
10-14, none above; mean 3.38.

Co-Authored-By: Claude Opus 5.5 <noreply@... (continued)

Coverage Stats

364 of 384 new or added lines in 10 files covered. (94.79%)

6 existing lines in 1 file now uncovered.

8875 of 9546 relevant lines covered (92.97%)

154.4 hits per line