IJHack / QtPass / 36006775383

93%

Build Type

push

github

Committed by web-flow

Commit Message

No function at cyclomatic complexity 15 or above (#1922)

* No function at cyclomatic complexity 15 or above

lizard puts eight functions at or over its warning line of 15. Each did
several things in one body; each is now the sequence it was, with the steps
named:

- Util::stageFileReplacing (20 -> 4): stage next to the destination, place
  it, check it is the file written; one fail() instead of eight
  "if (error)" branches.
- ConfigDialog::validate (20 -> 4): problemsOf() finds what is wrong with a
  profile, showProblems() marks it.
- ImitatePass::Init (17 -> 10): refuseLinkedGpgIdFolder(),
  settleSignature(); the two re-encrypt tails were the same and are one.
- loadRecord (16 -> 6): parseRecord() and recordEntry() read the JSON.
- UsersDialog::loadRecipients (15 -> 4): showRecipientWarning() and
  selectRecipients(). It asked gpg for the same keys twice; once is enough.
  It also only looked for recipients missing from the keyring when there
  were more recipients than keys found, so one email answering to two keys
  could hide a missing third; it always looks now.
- ImitatePass::writeGpgIdFile (15 -> 10): addGenerationHeader().
- FirstRunWizard::accept (15 -> 5): initialiseStore(), initialiseGit().
- Util::removeTree (15 -> 9): removeEntry() for a link or a file.

Translated strings keep their contexts: the Util helpers spell out
QCoreApplication::translate("Util", ...), since lupdate cannot give a
free function's tr() a context.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Users dialog: a recipient named by long or short key ID is found

selectRecipients() compared each .gpg-id line with the key IDs gpg
returned, but those are fingerprints, and a list may name a key by its long
or short ID (0x-prefixed or not). The count check this PR removed happened
to hide that: with one such recipient gpg found one key and nothing was
compared. Without it the resolved ke... (continued)

Coverage Stats

241 of 252 new or added lines in 7 files covered. (95.63%)

2 existing lines in 2 files now uncovered.

8827 of 9498 relevant lines covered (92.94%)

154.89 hits per line