IJHack / QtPass / 35996678399

93%

Build Type

push

github

Committed by web-flow

Commit Message

Comments that say why, once (#1920)

* Comments that say why, once

src/ carried about 8.5k comment lines against 12.8k lines of code. Much of it
in the .cpp files was one of three things:

- Doxygen blocks above definitions that restated the header's doc for the
  same function. Doxygen only reads the headers (FILE_PATTERNS = *.h), so
  these were never rendered, and a few had drifted onto the wrong function
  (onDelete's above confirmDeletion, reencryptSingleFile's above
  decryptEntry, a "still quite experimental" above verifyGpgIdForDir).
- Generated padding: @example sections such as "ConfigDialog dialog;
  dialog.on_accepted(); // Expected output: ..." and "@return void - This
  method does not return a value."
- Inline essays of five to twelve lines where two said the same.

Those go. What stays, shortened where it could be, is every reason a reader
cannot get from the code: security invariants (what output may carry a
secret, owner-only files, what must not be written through), platform traps
(Windows clipboard and WM_CLOSE, Qt 6.11's rebuilt widgets, Breeze palettes),
ordering constraints (the executor starts the next item only after
finished() returns), and every issue reference. A .cpp block that held a why
its header lacks became a one-to-three line // comment above the definition.

Comments only: stripped of comments, all 17 files are token-for-token what
they were. 2,690 lines out, 424 in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* Four comments that claimed more than the code does

The OTP display filter covers the parsed view, not "as-is"; a failed
record transaction may have read and rejected the file; the text browser
clears on a timer only with panel autoclear set; and the executor fails an
empty executable rather than dropping it, so keygen's own branch is about
the signal and reason its dialog waits for.

Co-Authored-By: Claude Opus 5.5 <norep... (continued)

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

8 existing lines in 5 files now uncovered.

8795 of 9467 relevant lines covered (92.9%)

151.37 hits per line