coreui / coreui-pro / 35994484061

95%

main: 94%

push

github

refactor(util): one source for the date and time helpers (#1415)

The date and time utils now carry what the React and Vue editions keep in
copies of their own, so those copies can import the utils instead: typed
editable and literal sections with isEditableSection, convertValue for the
value a date, date and time or time field is given, getDateWithin,
formatDateWithin, isDateSelectableWithin and getHourCycle for a field
layout, createDateFormatter, getTabStop and getSelectableDates for the
calendar grid, and convertTimeToDate, getAmPm and the time types.

The vanilla components use the same functions instead of their own
versions: Calendar formats through createDateFormatter, DateInput,
TimeInput and SectionInput convert values through convertValue,
SectionInput.isDateSelectable normalizes through getDateWithin, and the
pickers read the hour cycle through getHourCycle. convertValue keeps the
vanilla reading of a time-only string, which only a time field accepts,
and isDateSelectableWithin rejects an invalid date as isDateSelectable
does, where the framework copies accepted it.

Every function in the three modules has JSDoc that describes what the code
does, and the util specs call each of them.

5955 of 6531 branches covered (91.18%)

Branch coverage included in aggregate %.

91 of 92 new or added lines in 7 files covered. (98.91%)

11034 of 11368 relevant lines covered (97.06%)

633.26 hits per line