coreui / coreui-pro / 35979973828

95%

main: 94%

push

github

fix(Calendar): page to midnight of the 1st in every time zone (#1413)

Paging copied the calendar date and moved the copy to the 1st, so the time of
day it carried could fall into a DST gap on either end. Setting midnight
first carried 01:00 into the 1st where the clock skips the source day's
midnight (America/Santiago on 6 September 2026); setting it last moved the
page to the 2nd where a gap on the 1st runs up to midnight (Europe/Paris on
1 March 1919).

The page is now built from the year and month alone: the Date constructor
gives the 1st, setFullYear keeps a year below 100 from turning into 19xx,
and setHours brings midnight back for such a year, whose time of day the
constructor took from the 19xx date (America/Santiago in year 42). A sweep
over every IANA zone, years -10 to 120 and 1880 to 2100 and three source
times of day gave the earliest instant of the 1st in all 21 million cases;
each of the three earlier orders failed some of them.

Specs emulate the three time zones through the DevTools protocol, reset the
override when the test finishes whatever its result, and each fails on the
order it guards. The year-below-100 spec starts at year 95, where the
constructor alone gives 1985.

5915 of 6505 branches covered (90.93%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

10989 of 11341 relevant lines covered (96.9%)

630.44 hits per line