coreui / coreui-pro / 35942408260

95%

main: 94%

push

github

refactor(SectionInput): one path for a typed character and for committing the sections (#1412)

SectionInput spread a typed character over three methods (digit, letter and
their shared tail), repeated the sync-and-update pair after every edit,
parsed its config a second time in the constructor after BaseComponent had
already done it, derived its state from the config in two places (the
constructor and setConfig), kept copy and cut as two copies of one handler,
and carried a stub that threw when a subclass forgot its default layout.

The class is abstract now, with _getDefaultSections declared abstract. A
character goes through _applyCharacter, every edit ends in _commitSections,
and the constructor and setConfig share _applyConfig. The host's validity
and filled classes and the hidden input's value are written once, by the
validation pass that always follows the render, so on a filled field whose
config sets `valid` or `invalid` the host lists those classes in another
order.

DateInput and TimeInput lose the static componentInterface, which only their
own data API called and which never shipped in a release; the data API calls
getOrCreateInstance like the pickers do.

New specs pin typing through beforeinput and its readonly guard, the section
attributes, a configured placeholder, the click on the field outside the
sections, the select-all paths (a second key, Delete, Ctrl+C and Tab, cut on
a readonly field, leaving it on blur), the paste order around inputDateParse
and the receiver it is called with, the clamp on blur and the data API of
both inputs.

5915 of 6505 branches covered (90.93%)

Branch coverage included in aggregate %.

89 of 90 new or added lines in 3 files covered. (98.89%)

10987 of 11339 relevant lines covered (96.9%)

627.95 hits per line