hyperledger-labs / fabric-smart-client / 35860782818

91%

Build Type

push

github

Committed by web-flow

Commit Message

test(view): increase coverage of platform/view/services/storage/driver/sql/sqlite (#1876)

The package sat at 38.4% with the coverage filter applied. The existing
tests build stores by hand and pass them to the shared suites in
sql/common, so the driver, its store constructors and the config path
were never exercised.

Builds a Driver through NewDriver against a temp-dir database and runs
the shared key-value and binding suites on the stores it returns, and
round-trips signer info and audit info through driver-built stores. This
covers the config path, the DB provider and NewPersistenceWithOpts end
to end. Also covers GetOpts' defaults and errors, WrapError's mapped,
unmapped and pass-through cases, the isolation-level map, the sanitizer,
RetryWriteDB's non-busy path, and open with pragmas skipped.

The key-value suite gets a fresh driver per store, as the Postgres test
does: the DB provider caches the connection by data source and each case
closes its store when done.

The package is now at 91.2%. What remains is RetryWriteDB's SQLITE_BUSY
retry, which needs two connections contending without a busy timeout,
and open-time failures -- sql.Open, the pragma Exec, the write-side open
after the read side succeeded -- that a valid temp-dir database does not
produce.

Fixes #1865

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

17 existing lines in 7 files now uncovered.

27590 of 31981 relevant lines covered (86.27%)

2307.31 hits per line