coreui / coreui-pro / 35938822750

95%

main: 94%

push

github

refactor(PickerBase): build the actions and the popup menu in one place (#1411)

* refactor(PickerBase): build the actions and the popup menu in one place

The three pickers each defined the same closure around
createControlGroupAction, and each built the popup menu, its toggle attributes
and the projected footer with the same dozen lines. PickerBase now has
_createAction and _createMenu; the pickers pass their class prefix, the body
and the footer action that needs today or now to be selectable. The base class
is abstract, so its seven stubs that threw "must be implemented" are gone.

coreui.min.js 94.96 -> 94.69 kB, coreui.js 134.26 -> 133.89 kB (gzip,
bundlewatch on both sides).

* test(PickerBase): cover the menu id, the footer classes and the actions the shared builders write

The popup id the toggle points at, the footer class of the time and range
pickers, the footer actions that stay enabled when only today cannot be picked,
the time picker's toggle attributes before the first open, and an icon kept
unsanitized when sanitize is false had no spec that would fail if _createMenu
or _createAction were wired wrong.

5907 of 6526 branches covered (90.51%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 4 files covered. (100.0%)

11034 of 11414 relevant lines covered (96.67%)

636.99 hits per line