coreui / coreui-pro / 35935381526

95%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(Calendar): one cell path for the day, month, quarter and year views (#1409)

* refactor(Calendar): one cell path for the day, month, quarter and year views

The month, quarter and year views each had their own attribute method and
their own copy of the cell template, and the state update after a click or a
hover restated the same attributes for rows and for cells. They now share
_cellPeriodAttributes, _cellHtml and _applyState, and util/calendar compares
periods through isPeriodDisabled, isPeriodSelected and isPeriodInRange instead
of nine per-unit functions. Cells and week rows share their event
registrations, and the four navigation buttons one template.

Day cells now carry data-coreui-date in the toDateString form the other views
and the React and Vue calendars already use.

coreui.js 144.21 -> 143.17 kB, coreui.min.js 95.57 -> 94.96 kB (gzip,
bundlewatch on both sides).

* fix(Calendar): call the cell renderers on the config, keep years below 100 when paging

The shared cell template called the renderX callbacks detached, so a renderer
reading `this` lost the config it got before. Paging built the new calendar date
with the Date constructor, which maps years 0 to 99 to the 1900s; it now moves
the year with setFullYear.

The migration guide names the nine per-unit comparisons util/calendar no longer
exports and their isPeriod* replacements, and the new data-coreui-date form of
day cells. Specs cover the renderer's meta and this, and that a day range
previews nothing on the month cells.

Coverage Stats

5909 of 6528 branches covered (90.52%)

Branch coverage included in aggregate %.

94 of 95 new or added lines in 2 files covered. (98.95%)

1 existing line in 1 file now uncovered.

11067 of 11454 relevant lines covered (96.62%)

630.75 hits per line