coreui / coreui-pro / 35930444609

95%

main: 94%

push

github

fix(PickerBase, DateRangeInput): let a global picker default reach its parts, keep a part's own global (#1408)

* fix(PickerBase, DateRangeInput): let a global picker default reach its parts, keep a part's own global

The pickers forwarded an option to their field, calendar or time
selection only when it differed from the picker's `Default`, and
`DateRangeInput` did the same for its two fields. `Default` is the
object a global override mutates, so `DatePicker.Default.selectionType =
'month'` counted as "left alone": the field got a month mask, the
calendar kept its day grid. The same comparison turned a globally
localised `ariaCleanerLabel`/`ariaPickerLabel` back into the English
date-and-time wording once `timepicker` was on.

Each module now keeps a copy of its defaults as they were when it
loaded, and the comparisons use that copy. A picker default changed
globally therefore reaches the parts and wins over a global default of
the part for the same option, while a picker left at its original
default still lets a part's own global override through
(`DateRangeInput.Default.ariaStartLabel` names the range picker's start
field). Comparing with the part's `Default` instead would have reversed
that. The JavaScript guide says how the two kinds of globals combine.

* build: raise the coreui.bundle.js and coreui.esm.js budgets by 0.25 KB

Keeping each picker's original defaults adds 113 B gzip to
coreui.bundle.js and 112 B to coreui.esm.js (measured against the built
base), which puts them at 154.13 KB and 143.07 KB against 154 KB and
143 KB. Both ceilings move by 0.25 KB.

* test(DatePicker, TimePicker): pin the global picker defaults reaching their parts

The date and time pickers' `_originalDefault` overrides had no spec of
their own: a global `DatePicker.Default.selectionType` reaching the
calendar and a global `TimePicker.Default.seconds` reaching the roll are
now checked. The guide keeps to what holds for every option, that a
picker default wins over a... (continued)

6037 of 6661 branches covered (90.63%)

Branch coverage included in aggregate %.

11 of 12 new or added lines in 5 files covered. (91.67%)

11172 of 11562 relevant lines covered (96.63%)

622.2 hits per line