coreui / coreui-pro / 35928347344

95%

main: 94%

push

github

fix(DatePicker, TimePicker): take the time columns' hour cycle from the field (#1406)

* fix(DatePicker, TimePicker): take the time columns' hour cycle from the field

The date picker worked out the hour cycle of its time selects from its
own `format`, so a mask given to the field through `inputOptions` gave a
24-hour field over 12-hour selects. The time picker gave the roll no
cycle at all, so the roll fell back to the locale's AM/PM guess, which
disagrees with the locale's own field layout in ko-KR and en-CA (12-hour
field, 24-hour roll). Both now read the cycle from the hour section the
field actually renders.

* fix(TimeSelection): mark the selected hour in the configured cycle

The columns were built in the configured `hourCycle`, but the selected
hour was still worked out from the locale's AM/PM guess. With the time
picker now handing the roll the field's cycle, a 24-hour field in en-US
marked "02" for 14:30 and Enter committed 02:30, and in ko-KR no hour
was marked in the afternoon. Both now use the same cycle.

6037 of 6661 branches covered (90.63%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 3 files covered. (100.0%)

11164 of 11553 relevant lines covered (96.63%)

619.76 hits per line