coreui / coreui-pro / 35924536487

95%

main: 94%

push

github

fix(DialogBase): close the popups left open inside a closing dialog (#1403)

* fix(DialogBase): close the pickers, dropdowns and comboboxes open inside a closing dialog

`_hideChildComponents()` hid tooltips, popovers and toasts, so a date
picker, dropdown or combobox left open inside a modal, offcanvas or
dialog survived the close: its panel stayed shown with live positioning,
the toggle kept `aria-expanded="true"` and the instance stayed in the
open set. It now also hides every instance of those families found on a
`.show` element inside the dialog, before `close()`.

* fix(DialogBase): look up the popup owners on every element of the dialog

Matching `.show` found only the families that put the class on the
element holding the instance. The context menu marks its menu and the
multi select its wrapper, while the instance lives on the trigger area
and the native `<select>`, so both stayed open with their scroll lock
and focus trap after the dialog closed. Every element of the dialog is
now checked against the owner keys; `hide()` is a no-op on a closed
instance of each family. The spec opens a context menu and a multi
select as well.

6034 of 6657 branches covered (90.64%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

11163 of 11552 relevant lines covered (96.63%)

616.6 hits per line