hyperledger-labs / fabric-smart-client / 35742768658

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(metrics): guard the no-separator case in GetPackageName (#1870)

GetPackageName sliced on strings.LastIndex(fullFuncName, "/") without
checking for -1. Go's main package has no separator in its fully
qualified function name, so a binary that creates a metric directly from
main resolves to main.main and crashes with "slice bounds out of range
[-1:]". The call reaches GetPackageName through the ordinary NewCounter
-> applyNamespaceSubsystem chain at the intended callerSkipFrames depth,
so no unusual call depth is required. Runtime frames such as
runtime.main are slash-free for the same reason.

Return the unqualified name when there is no separator, mirroring the
guard in platform/view/services/tracing/config.go.

Fixes #1869

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

14 existing lines in 6 files now uncovered.

27532 of 31972 relevant lines covered (86.11%)

2762.56 hits per line