hyperledger-labs / fabric-smart-client / 35735696070

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(runner): guard the output cardinality in the serial implementations (#1873)

serialRunner.Run and serialExecutor.Execute indexed their ExecuteFunc
result at [0] without checking its length, so an executor returning an
empty or nil slice panicked with "index out of range [0] with length 0".

The batched sibling validates this same one-output-per-input contract at
batch.go:97 before pairing outputs to inputs, so the two implementations
of BatchRunner and BatchExecutor disagreed on whether it is checked. Both
serial methods already return an error, so they report the mismatch
rather than panicking; the batcher runs on a background goroutine with no
error channel back to the caller and has to panic instead.

Document the requirement on ExecuteFunc, since both implementations rely
on it and it constrains caller-supplied executors.

Fixes #1871

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

11 of 11 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

27534 of 31969 relevant lines covered (86.13%)

2359.46 hits per line