hyperledger-labs / fabric-smart-client / 35750882730

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): treat a block with no header as a query failure (#1875)

GetBlockNumberByTxID dereferenced block.Header.Number with no nil check.
The bytes come from a qscc GetBlockByTxID query against a remote peer,
and Header is an optional protobuf message, so a block carrying no header
unmarshals without error, leaves Header nil, and panics the client with a
nil pointer dereference.

Use the nil-safe GetHeader() getter and report a missing header as a query
failure, matching platform/fabricx/core/ledger and the nil Data and
Metadata guards in Block.DataAt and Block.ProcessedTransaction.

Fixes #1874

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

11 existing lines in 5 files now uncovered.

27537 of 31976 relevant lines covered (86.12%)

2673.49 hits per line