IJHack / QtPass / 35698271281

93%

Build Type

push

github

Committed by web-flow

Commit Message

One staged write for entries, copies and .gpg-id files; re-encryption goes through it too (#1904)

* One staged write for entries, copies and .gpg-id files; re-encryption goes through it too

Three copies of "create a temporary next to the destination, fill it through
its handle, sync, rename it into place, check the name is not a link" had
grown: Util::writeFileReplacing() for bytes, a static copyFileReplacing() in
imitatepass.cpp for Copy(), and ImitatePass::placeEncryptedFile() for Insert().
util.cpp now has one stageAndReplace() behind Util::writeFileReplacing() and
the new Util::copyFileReplacing(); Copy() and placeEncryptedFile() call the
latter. The copy is owner-only whatever the source's mode, as pass's own cp
under its umask 077 makes it.

reencryptSingleFile() still had gpg write into a temporary created next to the
entry: exclusive and unguessable, but gpg then opened it by name, so the same
window Insert() closed in #1882 remained. gpg now writes into a QTemporaryDir
outside the store, the ciphertext is verified there, and placeEncryptedFile()
replaces the entry in one rename. That retires the two-rename dance through
<entry>.reencrypt.bak with its restore-on-failure branches and three user-facing
messages; recoverReencryptLeftovers() stays, since 1.8.x wrote those names.

Four re-encryption tests follow the new flow (gpg output outside the store; a
vanished entry, a vanished ciphertext and a read-only store each leave the
entry untouched and say why), and tst_util covers copyFileReplacing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* lupdate + best-effort translations for the two Util read messages

Six ImitatePass strings went with the code they belonged to; "Cannot read %1."
and "Cannot read %1: %2" are new in the Util context and filled in for every
catalog but en_US, he and ru, kept type="unfinished" for Weblate review.

Co-Authored-By: Claude Opus 5... (continued)

Coverage Stats

40 of 52 new or added lines in 2 files covered. (76.92%)

10 existing lines in 2 files now uncovered.

8766 of 9432 relevant lines covered (92.94%)

147.79 hits per line