IJHack / QtPass / 35721653780

93%

Build Type

push

github

Committed by web-flow

Commit Message

PasswordDialog: the "typed in" mark belongs to the OTP field, not the dialog (#1905)

#1903 made the textEdited connection work, and with it a dialog-wide flag
became a bug: hookOtpField() never disconnected the field that used to be the
OTP one, so typing into a renamed-away field set the flag, and the next
editingFinished() rewrote the loaded value of the field that is the OTP one
now (a backup code like 12345678 looks like base32 and became an otpauth URI).
The mark is a property on the line edit the user typed in, read from the field
that is the OTP one; hookOtpField() disconnects the previous field when the
role moves; removeField() disconnects the removed line before hide() takes its
focus (editingFinished() fired into normalizeOtpField() for a field that was
gone); ~PasswordDialog() disconnects every line before QDialog hides the
window, which reached a slot of the destroyed part (a debug build asserted);
and ~FieldLabel() deletes its rename editor, a sibling that stayed behind as a
focused zombie when the field was removed mid-rename.

Four tests, each red on the previous source; the bare-secret normalisation test
runs in a fresh dialog so its keystrokes are what marks the field. CHANGELOG
entry: the unconnected handler has been in 1.8.0 and 1.8.1.


Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

15 of 15 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

8776 of 9443 relevant lines covered (92.94%)

148.49 hits per line