IJHack / QtPass / 35698254431

93%

push

github

PasswordDialog: removing a field no longer deletes it mid-request; typed OTP secrets are normalised (#1903)

removeField() called QFormLayout::removeRow(), which deletes the label and
the line at once. The request arrives from inside the label's
contextMenuEvent(), whose stack QMenu is parented to that label (QObject's
destructor then delete()s a stack object), or from inside the line's own
trailing action's triggered(). The row is now taken out of the form and its
widgets are deleted once control is back in the event loop.

hookOtpField() connected the textEdited handler as a lambda with
Qt::UniqueConnection, which Qt refuses for functors ("unique connections
require a pointer to member function of a QObject subclass"): the connection
was never made, m_otpFieldEdited stayed false, and a bare base32 secret the
user typed was never canonicalised on leaving the field. The handler is a
member function now.

The context-menu test drives Remove field as well, and the normalisation test
covers the typed bare secret.


Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

10 of 11 new or added lines in 1 file covered. (90.91%)

8796 of 9471 relevant lines covered (92.87%)

146.68 hits per line