ruby-grape / grape / 35461128033

99%

push

github

Let go of the mount instances a refresh replaces (#2964)

Every DSL step an API takes after a `mount` refreshes that mount: it drops
the endpoint serving the mounted API and mounts it again, which builds a new
instance of it. Each instance registers itself with its API (see
Grape::API::Instance.base=) so steps recorded later replay onto it, and
nothing ever took the replaced one back out. So every declaration after a
mount left another full copy of each mounted API alive, and of every API
mounted inside those, since re-mounting one replays its own refreshes too.

Three resources of twenty routes, each mounting a shared API, mounted into
a root that declares twenty more routes: master keeps 22 instances of each
resource and 1387 of the shared API; this keeps 2 and 7 -- each API's own,
plus one per place it is actually served.

drop_endpoints_mounted_for now releases the instance behind each endpoint
it drops, and the instances of the APIs mounted inside it, from the APIs
that keep them. They are no longer served, so no later step needs to reach
them either. The refresh itself is unchanged.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1451 of 1507 branches covered (96.28%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

4307 of 4307 relevant lines covered (100.0%)

28756.31 hits per line