ruby-grape / grape / 35460857222

100%

push

github

Stop recording a setting read on an API class as a setup step (#2963)

Every DSL method called on a Grape::API class is recorded as a setup step,
so it can be replayed on each mount of the API, and every step that is not
a `mount` refreshes the mounts made before it. That held for reads too:
`MyAPI.version`, `.prefix`, `.namespace`, `.cascade`, `.format`, `.logger`
and the like, called with nothing to set, were recorded and triggered the
refresh -- which re-mounts through `mount` and so calls `change!`,
discarding the compiled API.

A read after boot therefore made the next request recompile the whole API,
and each read grew the API's setup by one step plus one per mount, while the
re-mount left another instance of every mounted API behind. On an API of
100 routes with one mount, a request that reads `MyAPI.version` took about
13 ms instead of 0.02 ms.

A method in SETTING_READERS called with no argument, keyword or block is
now answered without being recorded: by the last instance, which is where
add_setup took its answer from, so the value is the one it returned
before. The list is explicit because being called bare is not enough --
`lint!` and a bare `get` still write -- and `helpers` stays out of it, as
called bare it includes the helpers in scope and calls `change!` itself.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1447 of 1503 branches covered (96.27%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

4301 of 4301 relevant lines covered (100.0%)

28699.64 hits per line