coreui / coreui-pro / 35436864482

94%

main: 94%

push

github

feat(pickers): let pickerIcon switch the button off (#1370)

* feat(pickers): let pickerIcon switch the button off

The four pickers typed the option as a string, so `pickerIcon: false`
threw and the button could not be removed, while Autocomplete and Multi
Select have taken a boolean all along and the migration guide promises
that contract for `pickerIcon` everywhere. An empty string got through
the type check and rendered an empty focusable button.

The option now takes a string or a boolean in the pickers too: `true`
is the built-in icon and the new default, a string is your own SVG, and
anything falsy renders no button.

PickerBase carried the popup's `aria-expanded`, `aria-haspopup` and
`aria-controls` on that button and dereferenced it in seven places, so
the field is now optional there: the writers skip when it is absent and
the type says so, which is how the compiler found the other six.

Without a button the popup has no pointer opener and nothing reports
the expanded state, so `show()` is the only way in. The option tables
say that.

* test(pickers): assert the popup opens without a toggle

The new specs only re-checked that no button was rendered, so they
passed whether or not `show()` did anything. They assert the popup
state now, and a new case pairs an author-written toggle with
`pickerIcon: false` to pin that the adopted button survives and still
takes `aria-expanded`.

The option tables no longer name the keyboard openers; the keyboard
section on each page already owns that.

5784 of 6398 branches covered (90.4%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 5 files covered. (100.0%)

10983 of 11373 relevant lines covered (96.57%)

540.26 hits per line