coreui / coreui-pro / 35409775949

94%

main: 94%

push

github

fix(SectionInput): stop the picker shortcut from changing the value (#1371)

The arrow branch ran whatever modifiers were held, so the shortcut that
opens the picker also moved the focused section: on a date field,
Alt+Down (Option+Down on macOS) dropped 14 to 13 and opened the calendar
in one keypress. Measured on every section of all four pickers, with and
without the toggle button: the value moved in all twelve cases.

The branch now declines exactly the combination the popup answers,
Alt+Down, so the keydown reaches the listener that opens it. Alt+Up
still steps the section, because nothing else consumes it; declining
both arrows would have left that key doing nothing at all.

A picker spec pins both halves together, since the two components were
only ever tested apart: the panel opens and the section holds its value.

The keyboard tables named the key as Alt alone, which is not what a Mac
keyboard shows.

5765 of 6378 branches covered (90.39%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

10971 of 11361 relevant lines covered (96.57%)

533.38 hits per line