coreui / coreui-pro / 35389512139

94%

main: 94%

push

github

fix(pickers): let seconds govern the field, not only the panel (#1364)

The time and date-time pickers always opened a panel with a seconds column
while their field had no seconds section, so a time picked to the second could
not be read back and the option the docs told you to use, `seconds="false"`,
only ever took the column away. Both pickers declare `seconds` now and pass it
to the field as well, so the two halves agree in both directions.

Measured in Chromium on the default build: the field goes from
`hour,minute,meridiem` to `hour,minute,second,meridiem` in the time picker and
gains the same section in the date-time picker, while the panel keeps its four
columns; with `seconds: false` the field drops to `hour,minute,meridiem` and the
panel to three columns.

This restores what v5 did rather than changing it: v5's pickers defaulted
`seconds` to true and formatted the value with them, so `10:30:00 AM` is what
both majors submit. With the section present the value completes once the
seconds are typed, which is how every other section of the field behaves, and
the field shows the `ss` placeholder until then.

React and Vue already defaulted `seconds` to true and passed it to their field,
so this closes a divergence rather than opening one.

4074 specs pass, four of them new, and both options tables say what a list or a
filter actually narrows: the panel, not the field.

5758 of 6371 branches covered (90.38%)

Branch coverage included in aggregate %.

10967 of 11357 relevant lines covered (96.57%)

528.09 hits per line