coreui / coreui-pro / 35372127314

94%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(pickers): put the shared shell in one place (#1363)

The four pickers are the same product with a different filling: a section
field, one or two bodies and a popup, joined by the value the picker owns.
`PickerBase` now holds the part that does not depend on that value, the way
`DialogBase` holds it for the modal family: `show`/`hide`/`toggle`, the popup
and its four events, the toggle and cleaner wiring, the footer action bridge,
option forwarding, the attributes adopted from markup the author wrote, and the
teardown order.

What stays in each picker is what actually differs: which bodies the popup
gets (`_onPopupShow`), what `reset()` and `clear()` restore, what `getContext()`
hands a footer button, which children `dispose()` owns, and its class list. The
date picker keeps the markup adoption nobody else has.

Two things are unified rather than moved. The element that opens the popup was
`_toggleElement` in the date picker and `_indicatorElement` in the other three;
it has one name now. And the body is built after the show classes go on, the
order the two time-bearing pickers already used because a time selection scrolls
the selected cell into view and needs layout to do it; the two calendar pickers
built theirs before. Measured in Chromium on all four, opened and closed and
disposed: host classes, `aria-expanded`, `aria-controls`, panel size, cell count
and the offset of the selected cell are identical, the time picker's scrolled
cell at 1px included.

2112 lines become 1846 across five files, and the minified bundle drops 592 B
gzipped. 4067 specs pass.

Coverage Stats

5758 of 6371 branches covered (90.38%)

Branch coverage included in aggregate %.

115 of 124 new or added lines in 5 files covered. (92.74%)

2 existing lines in 2 files now uncovered.

10967 of 11357 relevant lines covered (96.57%)

524.29 hits per line