coreui / coreui-pro / 35142459904

95%

main: 94%

push

github

fix(pickers): point aria-controls at the panel only while it exists (#1358)

The toggle got aria-controls when the picker was built, but the panel is only
in the document while it is open: Popup mounts it on show and removes it on
hide. So the reference was invalid before the first open and again after every
close, which is an axe aria-valid-attr-value violation and a relationship
assistive technology drops.

A first version of this wrote the attribute on show and stopped there, on the
strength of a measurement I read synchronously after hide, before the panel had
gone. Read again once it had, the reference was dangling exactly as before for
every closed picker that had been opened. The attribute is removed on hide now,
so it exists when its target does and never otherwise, which is what the React
and Vue editions already do through a shown flag.

In DatePicker both writes go through one dispatcher, so a toggle the author
supplied is recorded for the give-back from #1357 and a toggle the picker built
is not.

The three docs pages and the four a11y notes that promised the attribute
unconditionally now say while the panel is open, and each picker suite asserts
the whole cycle rather than the open half.

5785 of 6427 branches covered (90.01%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 4 files covered. (100.0%)

11125 of 11526 relevant lines covered (96.52%)

510.17 hits per line