coreui / coreui-pro / 35140093508

95%

main: 94%

push

github

fix(DatePicker): take back what it wrote on the parts the author supplied (#1357)

A toggle or cleaner the page writes is adopted rather than rebuilt, and the
picker stamps it: aria-label, aria-controls, aria-expanded, aria-haspopup and
aria-hidden on its svg, plus disabled when the picker is. None of it was taken
back. Measured on a built bundle: after dispose the author button still reads
aria-haspopup="dialog" with aria-controls pointing at a menu Popup.dispose() had
already removed, so the page is left with a button announced as the trigger of a
dialog that does not exist, and a disabled picker leaves it dead for good.

Every attribute written on an adopted part is recorded once, with what was there
before and with what the picker wrote, and dispose puts it back: removed where
the picker added it, restored where the author had their own.

Four details, each measured, that a first version got wrong:

The give-back runs after the popup is disposed, not before, because Popup.hide
writes aria-expanded on the way down and was re-stamping a button the loop had
just cleaned.

A value the page changes while the picker lives is left alone: the restore only
fires where the picker own value is still in place, the same rule the class
handling already follows.

A part the picker builds is not recorded at all, since dispose removes it; the
record now holds only what its name says.

Disabling still goes through the property so a custom element that does not
reflect it is disabled as before, while the attribute is what gets given back.

Two more ceilings go up 0.5 kB, measured on this build: coreui.bundle.min.js had
37 bytes left and coreui.js 95, which is the gap the next merge closes for
someone else.

5785 of 6427 branches covered (90.01%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 1 file covered. (100.0%)

11120 of 11521 relevant lines covered (96.52%)

506.33 hits per line