coreui / coreui-pro / 35339038780

95%

main: 94%

push

github

refactor(scss): move Sass scalars into the token maps (#1359)

* refactor(scss): move component Sass scalars into the token maps

879 scalars across 63 partials existed only to carry a value one line down
into the component's defaults() map. The value now sits in the map, so each
one has a single home and a component's styling surface is its tokens.

The global knobs in _config.scss and _root.scss are untouched, and so is every
component variable that a rule, a mixin or another partial still reads. The
compiled CSS is byte-identical across all 154 stylesheets.

31 docs pages lose the `### Sass variables` section whose block is now empty;
the migration guide says what to set in its place.

* refactor(scss): leave the root stylesheet with no variables of its own

_root.scss declared 62 scalars that existed only to carry a value into the
root token map. The values sit in the map now, so the file keeps a single
`$root-tokens` override point and the page-wide knobs are the tokens they
always emitted: --cui-btn-input-*, --cui-control-*, --cui-focus-ring-*,
--cui-backdrop-*, --cui-font-sans-serif, --cui-body-line-height.

The compiled CSS is byte-identical across all 154 stylesheets. Fourteen docs
pages lose a citation of a block that no longer exists; the three control pages
and the forms overview gain one, because --cui-control-* and --cui-btn-input-*
were emitted but never written down.

* refactor(scss): read the root stylesheet in the order the tokens ship

The file built the palette first, then the loops, then the literal map. It now
declares the literal map first and loops over it afterwards, which is the order
the tokens appear in on :root, so a reader follows one sequence instead of
jumping between an accumulator and its source.

Within the map the tokens follow the sequence they have upstream, so a diff
against their file is a matter of the entries we add rather than of where
everything sits. Every scss-docs block keeps exactly the keys it had, so ... (continued)

5785 of 6427 branches covered (90.01%)

Branch coverage included in aggregate %.

11127 of 11526 relevant lines covered (96.54%)

510.53 hits per line