coreui / coreui-pro / 35115656050

94%

push

github

fix(MultiSelect): leave the search field named after what it does (#1347)

Naming the search field after the page's label was wrong. What that field holds
is a filter, not the component's value, which lives in the selection, so
announcing it as the labelled field tells a screen reader the user is editing a
value they are not. It keeps a name of its own.

The name it keeps is ariaSearchLabel, and the default moves from Search to
Search options, which at least says what the field does. On a page with more
than one multi select they still all announce the same thing, so the
accessibility section now tells authors to set the option per control and shows
how.

With search enabled the element carrying the combobox role has no tab stop, so
the page's own name reaches the combobox and not the field the user tabs to.
Closing that means the text input carrying the role itself; the v6 MultiSelect
has the same shape, so it is not waiting there either. Recorded in the register
rather than patched over here.

4094 of 4507 branches covered (90.84%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

7434 of 7716 relevant lines covered (96.35%)

727.1 hits per line