coreui / coreui-pro / 35120929554

94%

push

github

fix(RangeSlider, DateRangePicker): take the global listeners down on dispose (#1351)

* fix(RangeSlider, DateRangePicker): take the global listeners down on dispose

Both components put listeners on nodes outside their own host and never took
them off: RangeSlider on window and on document.documentElement, DateRangePicker
on window and on the surrounding form. Each callback was a fresh closure per
construction, so every instance left handlers behind that keep the disposed
instance and its host alive.

Every one of those handlers is stored and removed by reference, and the removal
also runs at the top of _addEventListeners. That second half matters more than
the first: update() re-runs the listener setup, so without it each update left
another orphan on window that no dispose could reach, and on RangeSlider that
orphan then ran against a nulled element and threw on every resize for the life
of the page.

RangeSlider had no dispose at all, so it also left everything it built in the
host. It now puts the host back through the shared helper, the way the
autocomplete, the time picker and the date range picker already do. The classes
accumulate into the record instead of replacing it, because update() re-enters
the init and the second pass adds nothing, which would otherwise leave the
record empty and the classes on the element.

The date range picker's resize was the only event in the file without a
namespace. It has one now, which is what lets an off by namespace reach it; a
bare off by type always could, so that is the only thing the namespace changes.
Nine of its option keys sat out of order and are sorted back, and the two
methods rows in the docs said dispose only clears stored data; they say what it
undoes.

* chore: raise the JavaScript bundlewatch ceilings

Storing every global handler so it can be removed by reference, plus the range
slider's new dispose and the idempotent listener setup, costs between 257 and
455 bytes gzipped per bundle, measure... (continued)

4101 of 4514 branches covered (90.85%)

Branch coverage included in aggregate %.

40 of 40 new or added lines in 2 files covered. (100.0%)

7462 of 7744 relevant lines covered (96.36%)

730.72 hits per line