coreui / coreui-pro / 35111289162

94%

push

github

fix(MultiSelect): give the combobox and the search field an accessible name (#1344)

The combobox had no accessible name at all. It now takes whatever the page gave
the select: aria-labelledby, else aria-label, else the associated label, which
gains an id when it has none and loses it again on dispose. With search enabled
the search field takes the same name, because that is the control the user tabs
to. A page that named nothing still gets no name rather than an invented one.

A label that wraps the select is skipped: the plugin's wrapper is inserted
inside it, so naming the combobox after that label would pull the combobox and
every selected value into its own name.

The register also asked for aria-hidden on the overlay select, to stop screen
readers announcing two controls for one widget. That is wrong here and the
measurement is now a spec: reportValidity on a required multi select focuses
that element, so hiding it would hand the browser a focus target no screen
reader can see. The select stays in the tree and the register says why.

4096 of 4509 branches covered (90.84%)

Branch coverage included in aggregate %.

25 of 27 new or added lines in 1 file covered. (92.59%)

7436 of 7718 relevant lines covered (96.35%)

726.93 hits per line