coreui / coreui-pro / 35106604790

94%

push

github

fix(MultiSelect, Autocomplete): honour a disabled option group (#1341)

* fix(MultiSelect, Autocomplete): honour a disabled option group

A group marked disabled did nothing at all. In MultiSelect the parser read
node.disabled on the option, which reflects only the option's own attribute, and
never read optgroup.disabled; in Autocomplete the group object kept the flag but
flattening emitted leaves only, so nothing downstream ever saw it. Every option
of a disabled group stayed focusable and clickable, select all took them, and
the group label looked like any other.

Both parsers now push the group's disabled state onto its options, so the class,
aria-disabled and the tab order follow, select all skips the group, and the
group label is greyed out with its options. MultiSelect also builds the native
select from the parsed options instead of the raw config, the way update()
already did, so the underlying option and optgroup elements carry the same
state.

The docs pages describe the option and group object and show a disabled group.

* chore: raise the JavaScript bundlewatch ceilings

Propagating the disabled state of an option group through both parsers costs
between 82 and 146 bytes gzipped per bundle, measured level 9 against the base
build: coreui.js +146 B, coreui.bundle.js +140 B, coreui.esm.js +132 B, and
82 to 124 B on the three minified ones.

The six JavaScript entries are raised together rather than only the three that
failed. The other three were passing with under 0.2 kB to spare, which is less
than a single small fix, so the next change would have hit the tripwire for
being second in line rather than for growing anything. Each now has roughly
0.5 kB of headroom. The CSS entries keep their limits; the two new rules cost
21 and 11 bytes against 2.6 kB of slack.

* chore(MultiSelect): sort three option keys back into place

selectFilteredLabel sat after the selectionType block in Default, and
selectAllLabel, selectAllMode and selectAllStyle we... (continued)

4076 of 4487 branches covered (90.84%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 2 files covered. (100.0%)

7411 of 7691 relevant lines covered (96.36%)

727.92 hits per line