coreui / coreui-pro / 35071959596

94%

push

github

fix(TimePicker): put the host back the way it was on dispose (#1327)

`dispose()` destroyed the popper, cleared the input timeout and
deactivated the focus trap, but removed no nodes and undid no classes, so
the input group, the input, the body and the dropdown stayed in the host.
Constructing the component a second time on the same element therefore
doubled the markup: measured 2 input groups and 2 inputs where there
should be one, with no explicit dispose anywhere, because the base class
disposes the previous instance for you. Date range picker measures 8
inputs where there should be 4 and is the next one to take.

The generated nodes are now removed with their listeners, the class names
are removed where the component added them, `aria-expanded` and the stray
`meridiem` data attribute go with them, and the `submit` handler the
component puts on the surrounding form is namespaced so it can be taken
off. Unnamespaced, it survived dispose and threw on the next submit.
`dispose()` returns early once the element is gone, because the second
call reached a deactivated focus trap and threw.

`container` did not work as documented in three ways. A selector was never
resolved, because the guard required the string to equal both `dropdown`
and `inline` at once, so a raw string reached `container.append`. The two
legacy aliases set the type but left themselves in `container`, so
`container: 'dropdown'` threw as well, and that is the value React and Vue
default this option to. A selector matching nothing now falls back to
`false` instead of reaching the type check as `null`.

The bookkeeping moves to `util/host.js`, shared with Autocomplete, which
had the same lines inline since the previous fix. Measured on clean
builds, the shared form costs what the two inline copies did and starts
paying back at the third component.

Four budgets go up. Measured on clean builds of both sides, the change
adds 348 B gzip to `coreui.bundle.js`, 320 B to `coreui.esm.js`, 344 B ... (continued)

4021 of 4431 branches covered (90.75%)

Branch coverage included in aggregate %.

27 of 27 new or added lines in 3 files covered. (100.0%)

7362 of 7642 relevant lines covered (96.34%)

711.72 hits per line