coreui / coreui-pro / 35077975009

94%

push

github

fix(DateRangePicker): put the host back the way it was on dispose (#1329)

Same defect the Autocomplete and the time picker had. `dispose()`
destroyed the popper, cleared two timeouts and deactivated the focus
trap, but removed no nodes and undid no classes, so the input group, all
four inputs and the dropdown stayed in the host. Constructing the
component a second time on the same element doubled them: measured 8
inputs where there should be 4, with no explicit dispose anywhere,
because the base class disposes the previous instance for you.

The generated nodes now go with their listeners, the class names are
removed where the component added them, and `aria-expanded` goes too. The
`data-coreui-toggle` attribute is removed only when the component added
it: it is the data API's entry point, so taking away one the page wrote
would stop the element initialising again.

The calendar and every time picker the dropdown builds are components
rather than markup, and they are disposed instead of being dropped with
their nodes, which used to leave them in the instance registry with their
listeners attached. The loop that builds one picker per calendar kept only
the first and the last in fields, so a third was unreachable; they are all
tracked now.

The date picker extends this class, and its own listeners on the host are
registered under this module's namespace while the base class removes its
own. Nothing took them off, so a disposed date picker still answered
Escape and threw on a nulled element. `dispose()` takes them off here.

The same PR corrects a regression it introduced in the time picker: the
`submit` handler on the surrounding form was namespaced and removed with
`off(form, namespace)`, which takes off every picker's handler on that
form, not just this one's. Both components now keep the handler and
remove it by reference.

`dispose()` returns early once the element is gone, because the second
call reached a deactivated focus trap and threw.

Three ... (continued)

4036 of 4447 branches covered (90.76%)

Branch coverage included in aggregate %.

33 of 33 new or added lines in 2 files covered. (100.0%)

7383 of 7663 relevant lines covered (96.35%)

725.14 hits per line