coreui / coreui-pro / 35064985570

94%

push

github

fix(Autocomplete): put the host back the way it was on dispose (#1324)

`dispose()` destroyed the popper and detached listeners but removed no
nodes and undid no classes, so the input group, both inputs, the buttons
and the dropdown stayed in the host, and the host kept the classes the
component had put on it. Every dispose then init cycle left another
complete set of controls behind, and with `container` set the dropdown
stayed in the container for good, since it never lived in the host at
all.

The generated nodes are now removed along with their listeners, innermost
first, and the class names are removed only where the component added
them. `autocomplete` is a documented initialization selector, so a page
that writes it keeps it, and the same holds for `disabled`. The validity
classes are outside that guarantee: construction toggles them from the
config, so it already takes an author's `is-invalid` off when the config
does not ask for it, and dispose can only put back what construction
left.

`dispose()` returns early once the element is gone, because
`super.dispose()` clears it and every read after that threw on a second
call. `_cleanerElement` joins the other element references in the
constructor: it was the only one left undefined, and `_updateCleaner()`
guards with `=== null`, so `{ cleaner: true, disabled: true }` threw
before this. Also drops a duplicated assignment of the indicator
reference.

Two unminified JavaScript budgets go up by a quarter of a kilobyte each.
Measured on clean builds of both sides: the change adds 99 B gzip to
`coreui.bundle.js` and 94 B to `coreui.esm.js`, which took both past
ceilings that had roughly 50 B of headroom left. `coreui.js` grew by the
same 99 B and now sits about 50 B under its own ceiling, so it is the
next one to trip; it is left alone here. The minified budgets are
untouched and still pass.

4015 of 4425 branches covered (90.73%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

7353 of 7633 relevant lines covered (96.33%)

704.85 hits per line