coreui / coreui-pro / 35000558696

94%

push

github

fix(Autocomplete): keep the hint out of the form data (#1323)

The hint is decoration: `readonly`, `aria-hidden`, out of the tab order.
It also carried a `name`, and `readonly` does not exempt a control from
serialization, so it was submitted with the form.

With `name` configured it took the very same name as the real input and
stands first in the markup, so the form carried two values under that
key. Most of the time the first one is an empty string, because the hint
is cleared whenever an option is picked and on every close, so
`FormData.get()` and any server reading a single value saw an empty field
for a control the user had visibly filled. Mid-typing the first value is
the suggestion the user had not accepted. Without `name` it added a stray
`<uid>-hint` key instead.

Nothing reads it, so the attribute is gone rather than renamed.

Three specs: a preselected option submits its label rather than an empty
string, typing with a live suggestion submits what was typed, and the
default configuration adds no second key.

4005 of 4415 branches covered (90.71%)

Branch coverage included in aggregate %.

7343 of 7623 relevant lines covered (96.33%)

704.79 hits per line